Implemented with ES6 classes, additional functionality. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
requested changes
Mar 6, 2017
JavaScript/3-classes.js
Outdated
|
|
||
| } | ||
|
|
||
| searchPos(searchPosition) { |
JavaScript/3-classes.js
Outdated
| findFirst(name) { | ||
| let current = this.first; | ||
|
|
||
| while (current !== null && current.name !== name) { |
There was a problem hiding this comment.
Можно даже current && current.name !== name
JavaScript/3-classes.js
Outdated
| let position = 0; | ||
|
|
||
| if (this.length < 0 || removePosition >= this.length) { | ||
| throw new Error('Position out of bounds.'); |
There was a problem hiding this comment.
Не принято ошибки бросать по таким поводам, лучше вернуть ошибку или false из функции
JavaScript/3-classes.js
Outdated
| let current = this.first; | ||
| let position = 0; | ||
|
|
||
| if (this.length === 0 || |
There was a problem hiding this comment.
Форматирование этого длинного условия нужно как-то причесать. Я думаю, что если разобраться в сути, то условие будет покороче.
tshemsedinov
approved these changes
Mar 7, 2017
JavaScript/3-classes.js
Outdated
| } | ||
|
|
||
| return current; | ||
| } | ||
|
|
||
| remove(removePosition) { | ||
| remove(remPos) { |
There was a problem hiding this comment.
Лучше просто pos, не нужно дублировать имя функции в ее аргументах
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented next methods: searchPos, remove, findFirst, findAll, find.